Repository navigation
fix(ci): Build Texel 1.08 under cmake 4 by raising the policy floor to 3.5 - #421
Merged
Merged
Conversation
…o 3.5
The texel:1.08 rung of the calibration ladders stopped building once the
runner image moved to cmake 4. Texel vendors a gtest for its tests whose
cmake file asks for cmake 2.8.12, and cmake 4 refuses to configure anything
that asks for less than 3.5:
CMake Error at test/gtest/CMakeLists.txt:56 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
The configure step now passes -DCMAKE_POLICY_VERSION_MINIMUM=3.5, which is
what cmake's own message suggests. The source, the pin and the build
options are unchanged, so what plays is still the rated release. A cmake
older than 4 ignores the variable and builds as before.
Built with cmake 4.4.4 and with cmake 3.28.3. Both binaries answer uci as
Texel 1.08.
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01EYmME6yiwe8qbHTU6UgM2z
Contributor
Speed against
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
texel:1.08rung of the calibration ladders stopped building when the runner image moved to cmake 4. Texel bundles a gtest for its tests whose cmake file asks for cmake 2.8.12, and cmake 4 refuses to configure anything asking for less than 3.5. In Calibrate runs 43527508936 and 43527512769 the rung played no games and was left out of the fit:The configure step in
scripts/opponent.shnow passes-DCMAKE_POLICY_VERSION_MINIMUM=3.5, which is what cmake's own message suggests. The repository, the pin and the build options are unchanged, so the rated release is still what plays. A cmake older than 4 ignores the variable.Checked. Built locally with cmake 4.4.4 and 3.28.3; both binaries answer
ucias Texel 1.08. The script tests pass (365). On the runner, Calibrate run 43553675050 from this branch built the opponent and is playing the rung.Generated by Claude Code